Hi, you've reached the website of Mark Menard, Freemason, developer, businessman, photographer, motorcyclist and all around nice guy.
The main joy in my life is Sylva, my loving partner and friend. (You will see plenty of pictures of her. Also check out our site.) My professonal career is running a consulting firm concentrating on business automation and custom software. I enjoy software development, motorcycles, photography, dancing, freemasonry and travel.
Here you will find galleries of my latest photos, thoughts on software development, freemasonry, the occassional politics, and other things. Enjoy your time here.
Mark
An ongoing photographic study of Freemasonry.
To contact Mark send an email to mark@mjm.net. You will receive an auto response from my mail server to verify you're not a spammer.
© Mark Menard 2002-2007
Just wondering
Mark,
Just wondering; why don't you rely on OGNL to instantiate the VRContext object ? I believe OGNL can also set fields (but I'm not sure it's enabled in S2). Wouldn't you agree that providing getters and setters on the VRContext for exactly this purpose is a good idea ?
Is there a reason why you're not relying on the XWork validation ? It would give you a lot more control, and it's completely seperated from your Action.
If you apply both tips, you'll find your Action to be another 40 lines (if not more) shorter, and a lot cleaner (of course, you'll have to create an additional validation file ..).
Cheers,
Phil